Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing build target argument #34

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Add missing build target argument #34

merged 1 commit into from
Oct 2, 2022

Conversation

filiptibell
Copy link
Contributor

Fixes #33

Copy link
Owner

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, we might have some fixes to do in Rojo and Remodel too.

@LPGhatguy LPGhatguy merged commit f69ee9f into LPGhatguy:main Oct 2, 2022
Dekkonot pushed a commit to rojo-rbx/rojo that referenced this pull request Jun 30, 2023
Fixes macOS aarch64 builds not actually outputting x86 binaries by
specifying the `--target` flag during compilation in the release
workflow. These are the same changes as [this PR in
Aftman](LPGhatguy/aftman#34), which had the same
issue, and uses the same workflow.
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
Fixes macOS aarch64 builds not actually outputting x86 binaries by
specifying the `--target` flag during compilation in the release
workflow. These are the same changes as [this PR in
Aftman](LPGhatguy/aftman#34), which had the same
issue, and uses the same workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arm64/aarch64 binaries don't get prioritized over x86
2 participants