Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling edchiefcomplaint members from HDRUK V2 Google sheet #37

Closed
wants to merge 1 commit into from

Conversation

@vvcb
Copy link
Member

vvcb commented Feb 28, 2023

Thanks @MattStammers .

I think #36 that @ccarenzoIC raised is subtly different and is around the feature engineering aspect.

Moreover, it will also break the current workflow around how missing or erroneous codes that are not in a refset are labelled.

Please see feature_maps.py for how this is achieved through a combination of the {category:[array of codes]} dictionaries that appear later in the same module and the refset members data that appears in nhsdd_snomed.py.

nhsdd_snomed.py is meant to be autogenerated using nhsdd_generator.py.

Happy to jump on a quick call this afternoon if it will help.

@MattStammers
Copy link
Author

Don't merge it if it will break the rest of the workflow. If @ccarenzoIC is also working on this then prioritize what she is doing as she has been working on this for far longer than I have (just tinkering with it this morning)

@ccarenzoIC
Copy link
Contributor

Yes, mine as @vvcb if for the feature engineering part. I will work on this during the week.

Thanks,

@ccarenzoIC
Copy link
Contributor

On my side, will push the feature engineering code for grouping the chief complaint (#36) tomorrow morning and let you know if I'm facing any problem. Apologies, got delayed with other projects

@ccarenzoIC
Copy link
Contributor

On my side, will push the feature engineering code for grouping the chief complaint (#36) tomorrow morning and let you know if I'm facing any problem. Apologies, got delayed with other projects

#40

@vvcb vvcb closed this Mar 13, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants