Update README.md about UWP, .NET MAUI, WIN UI 3 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0nathan550
changed the title
Lachee
requested changes
Feb 10, 2024
There was a problem hiding this comment.
Just minor wording concerns here and general clues as to what might be blocking the UWP.
I dont like the implication that the library loads external exes. The only thing it does load is Newtonsoft.JSON's dll.
Discord handles the execution of the game's exes themselves.
README.md
Outdated
|
|
||
| **UWP / .NET MAUI / WIN UI 3** | ||
|
|
||
| In order to make this library work with the UWP applications, you need to define `runFullTrust` Capability inside of `Package.appxmanifest`. It's done this way because library loads external .exe in order to make library work. |
There was a problem hiding this comment.
this library does not load exeternal exes, or any exes actually. Please reword this.
some potential causes could be:
- use of registry keys in WindowsUriSchemeCreator.cs
- use of pipes in ManagedNamedPipeClient.cs
but unless verified what is causing it, please only mention that runFullTrust is required.
From reading the capability declarations, it could also be from .JSON using JIT capabilities, although this is not a restricted capability (Code Generation).
Lachee
approved these changes
Feb 10, 2024
|
awesome! thanks for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of #236
Problem was that UWP applications along with .NET MAUI and WIN UI 3 requires certain capabilites and trust in order to load this library, without it the library doesn't do anything, because UWP blocks all restricted movement of loading external .exe's.
It doesn't fire any exception in the library, but after digging I figure out why this was the error. And again, error was in restrictions.
It's good to change README.md because, there can be people like me who don't understand why this doesn't work.
And until we will find out what capabilites we need to provide to UWP, it's okay to put
runFullTrust, because that's the only way make it work.I hope you understand that, waiting for the possible approve.