-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email template #141
Email template #141
Conversation
<meta name="viewport" content="width=device-width" /> | ||
<meta http-equiv="Content-Type" content="text/html" charset="UTF-8" /> | ||
<title>Подтверждение email</title> | ||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(if-minor)
Можно вынести стили в отдельный css-файл?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
я точно так и не поняла, можно ли выносить в отдельно.
в одном месте читала, что нельзя вообще ничего подключать, в другом месте, что стили нужно прописывать атрибутами, а не в тегах style.
посмотрим, как получится первое письмо у бэка. может попробуем вынести в отдельный файл, так, конечно, будет лучше
} | ||
|
||
body { | ||
background-color: #FFFFFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking)
Можно сократить до #fff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
везде, где читала, рекомендуют использовать полное шестнадцатеричное представление
|
||
</head> | ||
<body> | ||
<table class="body"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue
Тег table
получается вложенным в body
, тогда должен быть отступ
<td class="container"> | ||
<div class="content"> | ||
|
||
<div class="header"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(if-minor)
Может использовать тег header
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
нет, потому что не поддерживается многими почтовыми клиентами
https://www.caniemail.com/features/html-semantics/
</tr> | ||
</table> | ||
|
||
<div class="footer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(if-minor)
Может использовать тег footer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
нет, потому что не поддерживается многими почтовыми клиентами
https://www.caniemail.com/features/html-semantics/
Верстка писем по макетам 3.1-3.5.
Отправила пока Максиму, он будет пробовать вставить это на бэк.
Иконки занесла в отдельную папку для удобства бэка.