deprecate(testing): CronableAssertions::assertCronableRegistered(),…

… please use `ScheduleAssertions::assertScheduled()` instead.
LastDragon-ru · Dec 20, 2023 · 018e3c1 · 018e3c1
1 parent 40fb8f6
commit 018e3c1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/packages/testing/README.md b/packages/testing/README.md
@@ -117,13 +117,12 @@ These assertions can be used without Laravel at all (#4).
 
 ## Laravel
 
-| Name                                                                                    | Description                                                          |
-|-----------------------------------------------------------------------------------------|----------------------------------------------------------------------|
-| [`assertDatabaseQueryEquals()`](./src/Assertions/DatabaseAssertions.php)                | Asserts that SQL Query equals SQL Query.                             |
-| [`assertScoutQueryEquals()`](./src/Assertions/ScoutAssertions.php)                      | Asserts that Scout Query equals Scout Query.                         |
-| [`assertCronableRegistered()`](./src/Assertions/Application/CronableAssertions.php#L30) | Asserts that [Cronable](../queue/README.md#cron-jobs) is registered. |
-| [`assertQueryLogEquals()`](./src/Database/QueryLog/WithQueryLog.php)                    | Asserts that `QueryLog` equals `QueryLog`.                           |
-| [`assertScheduled()`](./src/Assertions/Application/ScheduleAssertions.php)              | Asserts that Schedule contains task.                                 |
+| Name                                                                       | Description                                                          |
+|----------------------------------------------------------------------------|----------------------------------------------------------------------|
+| [`assertDatabaseQueryEquals()`](./src/Assertions/DatabaseAssertions.php)   | Asserts that SQL Query equals SQL Query.                             |
+| [`assertScoutQueryEquals()`](./src/Assertions/ScoutAssertions.php)         | Asserts that Scout Query equals Scout Query.                         |
+| [`assertQueryLogEquals()`](./src/Database/QueryLog/WithQueryLog.php)       | Asserts that `QueryLog` equals `QueryLog`.                           |
+| [`assertScheduled()`](./src/Assertions/Application/ScheduleAssertions.php) | Asserts that Schedule contains task.                                 |
 
 # Laravel Response Testing
 

diff --git a/packages/testing/src/Assertions/Application/CronableAssertions.php b/packages/testing/src/Assertions/Application/CronableAssertions.php
@@ -20,6 +20,8 @@
 use function str_contains;
 
 /**
+ * @deprecated 5.3.1 Please use {@link ScheduleAssertions} instead.
+ *
  * @required {@link \Illuminate\Foundation\Testing\TestCase}
  *
  * @property-read Application $app
@@ -30,6 +32,8 @@ trait CronableAssertions {
     /**
      * Asserts that {@link \LastDragon_ru\LaraASP\Queue\Contracts\Cronable} is registered.
      *
+     * @deprecated 5.3.1 Please use {@link ScheduleAssertions::assertScheduled()} instead.
+     *
      * @param class-string<Cronable> $cronable
      */
     protected function assertCronableRegistered(string $cronable, string $message = ''): void {
@@ -40,6 +44,8 @@ protected function assertCronableRegistered(string $cronable, string $message =
     }
 
     /**
+     * @deprecated 5.3.1
+     *
      * @param ConfigurableQueueable|class-string<ConfigurableQueueable> $queueable
      * @param array<string, mixed>                                      $settings
      */
@@ -54,6 +60,8 @@ protected function setQueueableConfig(ConfigurableQueueable|string $queueable, a
     }
 
     /**
+     * @deprecated 5.3.1
+     *
      * @param class-string<Cronable> $cronable
      */
     protected function isCronableRegistered(string $cronable): bool {