Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blsagg service doesn't returned sorted operator pubkeys #187

Closed
samlaf opened this issue Apr 8, 2024 · 2 comments
Closed

blsagg service doesn't returned sorted operator pubkeys #187

samlaf opened this issue Apr 8, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@samlaf
Copy link
Collaborator

samlaf commented Apr 8, 2024

Describe the bug

checkSignatures expects nonsigner operator pubkeys to be sorted, but the blsagg service currently doesn't sort operator pubkeys. See

func getG1PubkeysOfNonSigners(signersOperatorIdsSet map[types.OperatorId]bool, operatorAvsStateDict map[types.OperatorId]types.OperatorAvsState) []*bls.G1Point {

To Reproduce
Don't have a reproducible test right now. This was raised by an avs team. Will need to add a test case for this.

@samlaf samlaf added the bug Something isn't working label Apr 8, 2024
@samlaf samlaf self-assigned this Apr 8, 2024
hezhihua81 added a commit to brevis-network/eigensdk-go that referenced this issue Apr 8, 2024
@i9
Copy link

i9 commented Apr 8, 2024

thanks! we hope this will also fix mismatched order of nonSignersOperatorIds and NonSignersPubkeysG1 (due to golang map iter random order)

hezhihua81 added a commit to brevis-network/eigensdk-go that referenced this issue Apr 8, 2024
hezhihua81 added a commit to brevis-network/eigensdk-go that referenced this issue Apr 8, 2024
hezhihua81 added a commit to brevis-network/eigensdk-go that referenced this issue Apr 8, 2024
hezhihua81 added a commit to brevis-network/eigensdk-go that referenced this issue Apr 8, 2024
samlaf pushed a commit that referenced this issue Apr 8, 2024
* fix issue #187

* fix issue #187

* fix issue #187

* fix issue #187

* fix issue #187
@samlaf
Copy link
Collaborator Author

samlaf commented Apr 10, 2024

Fixed in #188

@samlaf samlaf closed this as completed Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants