[Fireblocks] Pass in gas info when calling contract #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
reviewed
Mar 24, 2024
ian-shim
force-pushed
the
fireblocks-gas-fees
branch
from
5f558cd
to
d0eb91d
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to rely on Fireblocks' gas estimation by passing in
HIGHasfeeLevelparameter when creating a transaction.However, this estimation doesn't guarantee that replacement (boosting) transaction increases the gas cost by > 15% than the previous transaction, which is a requirement for replacing a pending transaction.
We need to explicitly pass in the gas fee cap and priority fee cap instead of passing in
feeLevelin this case.