Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVS-507: Integration test scaffold: add anvil chain with deployed contracts to be able to test sdk features like bindings, txmgr, etc #176

Merged
merged 12 commits into from
Jun 14, 2024

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Apr 4, 2024

Ready for review.

TODO:

  1. update deploy script to also deploy avs contracts
  2. Fix egnaddr test to use these deployed contracts instead of the hardcoded file it currently uses

@samlaf samlaf marked this pull request as draft April 4, 2024 02:49
@samlaf samlaf mentioned this pull request May 15, 2024
3 tasks
@samlaf samlaf force-pushed the chainio-integration-tests branch from 083bd7f to a6de9e1 Compare June 9, 2024 02:43
@samlaf samlaf marked this pull request as ready for review June 9, 2024 03:44
@samlaf samlaf requested a review from shrimalmadhur June 9, 2024 03:44
this requires the changes in Layr-Labs/eigenlayer-contracts#495 to be merged first

make generate-bindings exit on error

update eigenlayer-middleware to head of dev branch

make bindings
@samlaf samlaf force-pushed the chainio-integration-tests branch from 2bff649 to 64198d5 Compare June 11, 2024 00:30
@samlaf samlaf marked this pull request as draft June 11, 2024 13:30
shrimalmadhur
shrimalmadhur previously approved these changes Jun 11, 2024
Comment on lines -11 to -15
// just copied this file from an eigencert deployment and hardcoded addrs below
// TODO(samlaf): eventually we should make updating this file automated
anvilStateFileName = "eigenlayer-and-registries-deployed-anvil-state.json"
serviceManagerAddr = "0x7a2088a1bFc9d81c55368AE168C2C02570cB814F"
registryCoordinatorAddr = "0x09635F643e140090A9A8Dcd712eD6285858ceBef"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses are no longer hardcoded. We get them from the ContractsRegistry that is deployed as part of the integration test deployment.

Erc20MockStrategy common.Address
}

func GetContractAddressesFromContractRegistry(ethHttpUrl string) (mockAvsContracts ContractAddresses) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function reads all important contract addresses from the ContractsRegistry contract deployed. We can then use these addresses to build sdk clients.

@samlaf samlaf changed the title Integration test scaffold: add anvil chain with deployed contracts to be able to test sdk features like bindings, txmgr, etc AVS-507: Integration test scaffold: add anvil chain with deployed contracts to be able to test sdk features like bindings, txmgr, etc Jun 12, 2024
@samlaf samlaf marked this pull request as ready for review June 12, 2024 09:21
@samlaf samlaf merged commit 1623b01 into master Jun 14, 2024
4 checks passed
@samlaf samlaf deleted the chainio-integration-tests branch June 14, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants