fix: duplicate operatorAddresses, operatorPubkeys caused by inclusive FilterQuery #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
reviewed
Apr 29, 2024
… nature of FilterQuery(fromBlock,toBlock)
taco-paco
force-pushed
the
fix/duplicate-log-query
branch
from
5ec99fd
to
0093b0e
Compare
samlaf
approved these changes
Apr 30, 2024
|
ty sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
What Changed?
Since FilterQuery is inclusive (as discussed here) to toBlock there were duplicates in every iteration, for example: [0,10000], [10000, 20000]
Would get block 10000 twice.
Reviewer Checklist