Samlaf avs 559 setup integration test for bls agg #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
force-pushed
the
samlaf-avs-559-setup-integration-test-for-bls-agg
branch
from
c020d95
to
3e2a0b5
Compare
| }) | ||
|
|
||
| t.Run("2 quorums 1 operator", func(t *testing.T) { | ||
| // TODO: Implement this test |
There was a problem hiding this comment.
this will come as a separate PR?
There was a problem hiding this comment.
yes. there's another issue for it
| @@ -761,6 +773,126 @@ func TestBlsAgg(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestIntegrationBlsAgg(t *testing.T) { | |||
There was a problem hiding this comment.
This test is unreadable. unclear what's happening: probably better to divide/refactor
- setup
- what is actually being tested
- add comments maybe?
There was a problem hiding this comment.
refactored in ba79798. Check now, hopefully its easier to read :D
samlaf
force-pushed
the
samlaf-avs-559-setup-integration-test-for-bls-agg
branch
from
ba79798
to
8af5916
Compare
shrimalmadhur
approved these changes
Jun 27, 2024
…repo was buggy for some reason)
…d on local machine
…ich doesn't need cast to be installed locally
samlaf
force-pushed
the
samlaf-avs-559-setup-integration-test-for-bls-agg
branch
from
8af5916
to
78ca745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
What Changed?
Created one integration test for a single quorum.
We'll be able to use this scaffold to augment this to 2 quorums and fix #261 (AVS-494)
Reviewer Checklist