Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add set claimer for to EL writer #282

Merged
merged 4 commits into from
Jun 27, 2024
Merged

add set claimer for to EL writer #282

merged 4 commits into from
Jun 27, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Jun 26, 2024 •
edited
Loading

Fixes # .

What Changed?

  • Add SetClaimerFor function in SDK
  • Changing the contracts argument reader and writer struct back to struct instead of interface due to usage restriction for nil checks. We are not using mocks for testing for those so it doesn't make sense to use to interface

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

samlaf
samlaf reviewed Jun 27, 2024
View reviewed changes
chainio/clients/builder.go Outdated Show resolved Hide resolved
chainio/clients/elcontracts/writer.go Outdated Show resolved Hide resolved
chainio/clients/elcontracts/writer.go Outdated Show resolved Hide resolved
@samlaf samlaf merged commit 2c8b1d5 into dev Jun 27, 2024
4 checks passed
@samlaf samlaf deleted the madhur-elo-186-add-setclaimer-function-in-eigensdk branch June 27, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @samlaf