Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fireblocks get asset addresses endpoint #307

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ian-shim
Copy link
Contributor

Updated the deprecated endpoint with new endpoint.
Tested that the response from this test before and after this change are identical: go test ./chainio/clients/... -v -run TestGetAssetAddresses

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@ian-shim ian-shim requested a review from samlaf July 23, 2024 19:32
@samlaf samlaf force-pushed the fb-update-asset-addresses-endpoint branch from 799aa78 to d6a9dd1 Compare July 23, 2024 20:17
@samlaf samlaf force-pushed the fb-update-asset-addresses-endpoint branch from d6a9dd1 to 3214756 Compare July 23, 2024 21:11
@ian-shim ian-shim merged commit 500607f into dev Jul 23, 2024
4 checks passed
@ian-shim ian-shim deleted the fb-update-asset-addresses-endpoint branch July 23, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants