refactor: handle zero bitmap #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
reviewed
Aug 30, 2024
| } | ||
| numBits := value.BitLen() | ||
| var quorums []bool | ||
| for i := 0; i < numBits; i++ { | ||
| quorums = append(quorums, value.Int64()&(1<<i) != 0) | ||
| } | ||
| if len(quorums) == 0 { |
There was a problem hiding this comment.
can you add a comment explaining when/why this case is possible? When does GetCurrentQuorumBitmap return a value of 0 bitlen?
There was a problem hiding this comment.
I think if operator has opt out from all quorums (or been ejected), the contract could return 0, you can see here:
There was a problem hiding this comment.
meant in the code, because it's surprising when reading the code why it could ever be 0.
samlaf
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup PR of #331. The functions works well with our system internally, but i just realized that if the bitmap is 0, the result array would be empty too. So is it better that we populate all existing quorums with default value (which is false in this case) to the result to be more consistent. Also wrap some errors this time.
What Changed?
Reviewer Checklist