Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to filter entities for which action diffs should be generated #601

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add ability to filter entities for which action diffs should be generated #601

wants to merge 13 commits into from

Conversation

zhaop
Copy link
Contributor

@zhaop zhaop commented Aug 19, 2024

Fixes #600.

@alice-i-cecile alice-i-cecile added usability Reduce user friction breaking-change A breaking change that requires a new major version labels Aug 19, 2024
@alice-i-cecile
Copy link
Contributor

A nice idea! Remember to update RELEASES.md

alice-i-cecile
alice-i-cecile reviewed Aug 19, 2024
View reviewed changes
src/action_diff.rs Outdated Show resolved Hide resolved
@zhaop
Copy link
Contributor Author

zhaop commented Aug 19, 2024

Okey I should be done! Let's see what CI thinks. I think with the changes to summarize this should no longer be a breaking change (so I put it in 0.15.1)?

zhaop
zhaop commented Aug 19, 2024
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@alice-i-cecile
Copy link
Contributor

This also can't go in 0.15.1, since it's breaking. We can either refactor it to be completely non-breaking, or wait until 0.16

@zhaop
Copy link
Contributor Author

zhaop commented Aug 20, 2024

I just re-read about semantic versioning and agree 0.16 is a better place for this. Added a new 0.16 section to RELEASES.md.

To ensure this PR doesn't go into 0.15.1, should it remain unmerged until after 0.15.1 is released? or do we make a branch for 0.16?

@alice-i-cecile
Copy link
Contributor

Because this is nicely isolated I'll just leave this unmerged for a bit. I mostly intend to hit examples and trigger-like inputs for 0.15.1, neither of which should conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

Assignees
No one assigned
Labels
breaking-change A breaking change that requires a new major version usability Reduce user friction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate action diffs for only a filtered set of entities
2 participants
@zhaop @alice-i-cecile