Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›fix(llm): typo when 1 account found after scan #7167

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jun 21, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Receive funds flow -> sync accounts with Ledger Device -> Scan OnChain Accounts

πŸ“ Description

Fix typo if there is only 1 account during sync
Instead of "1 accounts found" we will have "1 account found" without the s

Before After
https://github.com/LedgerHQ/ledger-live/assets/73439207/e6da81eb-448c-403f-bc04-c99ab2cbc0ec https://github.com/LedgerHQ/ledger-live/assets/73439207/b63d1432-d633-4751-9cac-fb5dbd7e65eb

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner June 21, 2024 14:24
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 1:06pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 1:06pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 1:06pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 1:06pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 1:06pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jun 21, 2024
@LucasWerey LucasWerey marked this pull request as draft June 21, 2024 15:03
@LucasWerey LucasWerey changed the title fix(llm): fix typo when 1 account found after scan πŸ›fix(llm): fix typo when 1 account found after scan Jun 24, 2024
@LucasWerey LucasWerey marked this pull request as ready for review June 24, 2024 12:00
@LucasWerey LucasWerey changed the title πŸ›fix(llm): fix typo when 1 account found after scan πŸ›fix(llm): typo when 1 account found after scan Jun 24, 2024
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can follow this doc to handle plurals :)

https://www.i18next.com/translation-function/plurals

@LucasWerey LucasWerey merged commit f6bcb5d into develop Jun 24, 2024
36 of 37 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-12978 branch June 24, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants