Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/cardano mobile #7196

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

pavanvora
Copy link
Contributor

@pavanvora pavanvora commented Jun 26, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Translation was missing for operationDetails.extra.deposit. This PR fixes that.
telegram-cloud-photo-size-5-6329829192488827916-y

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 5:57am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 5:57am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 5:57am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 5:57am

Copy link

vercel bot commented Jun 26, 2024

@pavanvora is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched fork Pull request base branch comes from a fork. labels Jun 26, 2024
@hedi-edelbloute hedi-edelbloute merged commit dfc9931 into LedgerHQ:develop Jun 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork Pull request base branch comes from a fork. mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants