[LIVE-13346][LLM][BLE] Device search in BLE during onboarding doesn't filter on the selected device #7318
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
jiyuzhuang
force-pushed
the
bugfix/live-13346
branch
from
5a30a6c
to
ff2e04c
Compare
| @@ -70,7 +70,7 @@ export const BleDevicePairingFlow: React.FC<Props> = ({ navigation }) => { | |||
| <Flex px={6} flex={1}> | |||
| <BleDevicePairingFlowComponent | |||
| key={keyToReset} | |||
| filterByDeviceModelId={DeviceModelId.stax} | |||
| filterByDeviceModelId={QRCodeDevices} | |||
There was a problem hiding this comment.
could be clearer with [DeviceModelId.stax, DeviceModelId.europa] here
There was a problem hiding this comment.
It's a list that contains all the devices with screen and could be (surely) extensible in the future, so let's maintain the list to avoid modifying everywhere when a new device comes out.
There was a problem hiding this comment.
This list could have a better name then, it's not clear to have QrCodeDevices filtered for BlePairingFlow imho
| if (Array.isArray(filterByDeviceModelId)) { | ||
| return filterByDeviceModelId.filter( | ||
| // This array should not contain `null` value, this is to make the type check pass | ||
| (v: FilterByDeviceModelId): v is DeviceModelId => v !== null, |
There was a problem hiding this comment.
IMHO, one char const/var should be avoided to understand more clearly :)
|
could you fill the PR description for |
✅ Checklist
npx changesetwas attached.filterByDeviceModelIdof componentBleDevicePairingFlowcan be passed an array ofDeviceModelIdwhich will be transferred directly to filter (already supported). This can allow us show all devices with screen after scanning a QR code (no device info included for now).📝 Description
❓ Context
🧐 Checklist for the PR Reviewers