Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds swap feedback form #7379

Merged
merged 6 commits into from
Jul 22, 2024
Merged

feat: adds swap feedback form #7379

merged 6 commits into from
Jul 22, 2024

Conversation

andreicovaciu
Copy link
Contributor

@andreicovaciu andreicovaciu commented Jul 19, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

LIVE-10089: Adds swap feedback form

❓ Context

LIVE-10089

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@andreicovaciu andreicovaciu requested a review from a team as a code owner July 19, 2024 12:16
@vercel Vercel
Copy link

vercel bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 8:43am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 8:43am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 8:43am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 8:43am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 8:43am

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Jul 19, 2024
liviuciulinaru
liviuciulinaru previously approved these changes Jul 22, 2024
View reviewed changes
@andreicovaciu
Copy link
Contributor Author

andreicovaciu commented Jul 22, 2024 •
edited by live-github-bot bot
Loading

@andreicovaciu

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@live-github-bot live-github-bot bot requested review from a team as code owners July 22, 2024 08:42
@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Jul 22, 2024
@andreicovaciu andreicovaciu merged commit 8bec338 into develop Jul 22, 2024
33 of 34 checks passed
@andreicovaciu andreicovaciu deleted the feat/LIVE-10089-add-feedback-form-link branch July 22, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liviuciulinaru liviuciulinaru liviuciulinaru approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@VicAlbr VicAlbr VicAlbr approved these changes

Assignees

@andreicovaciu andreicovaciu

Labels
desktop Has changes in LLD screenshots Screenshots have been updated translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreicovaciu @liviuciulinaru @ypolishchuk-ledger @VicAlbr