Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recover to support all devices but LNS #7539

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

cksanders
Copy link
Contributor

@cksanders cksanders commented Aug 7, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

We added this banner on May 12, 2023, due to us not supporting NS & NS+

This PR is to remove the banner for LNS+, to ensure a user can use Recover Restore with LNS+.

Additionally, this PR resolves the discrepancy between the prettier write and check.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cksanders cksanders requested review from a team as code owners August 7, 2024 09:31
Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 11:46am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 11:46am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 11:46am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 11:46am
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 11:46am

@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Aug 7, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 97I
Total 0C 0H 0M 0L 97I
Secrets 0πŸ”‘

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Aug 7, 2024
KVNLS
KVNLS previously approved these changes Aug 7, 2024
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cksanders cksanders force-pushed the fix/PROTECT-3281-nsp-support branch from 41d23f0 to a452d2d Compare August 8, 2024 11:46
@cksanders cksanders merged commit 9581686 into develop Aug 8, 2024
34 checks passed
@cksanders cksanders deleted the fix/PROTECT-3281-nsp-support branch August 8, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants