Feat/llm ledger sync redirection on sync again #7729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
cgrellard-ledger
force-pushed
the
feat/llm-ledger-sync-redirection-on-sync-again
branch
from
27bb455
to
8ce087f
Compare
cgrellard-ledger
force-pushed
the
feat/llm-ledger-sync-redirection-on-sync-again
branch
from
8ce087f
to
84dcd64
Compare
LucasWerey
reviewed
Sep 3, 2024
apps/ledger-live-mobile/src/newArch/features/WalletSync/hooks/useSyncWithQrCode.ts
Outdated
Show resolved
Hide resolved
cgrellard-ledger
force-pushed
the
feat/llm-ledger-sync-redirection-on-sync-again
branch
2 times, most recently
from
1e91120
to
c5d7221
Compare
apps/ledger-live-mobile/src/newArch/features/Accounts/screens/AddAccount/index.tsx
Outdated
Show resolved
Hide resolved
...edger-live-mobile/src/newArch/features/Accounts/screens/AddAccount/useAddAccountViewModel.ts
Outdated
Show resolved
Hide resolved
.../ledger-live-mobile/src/newArch/features/WalletSync/screens/Activation/ActivationSuccess.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/Settings/General/WalletSyncRow.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const closeDrawer = useCallback(() => { | ||
| dispatch(setLedgerSyncActivateDrawer(false)); | ||
| }, [dispatch]); | ||
| setCurrentStep(Steps.Activation); |
There was a problem hiding this comment.
It's the only file that we need to do that?
There was a problem hiding this comment.
Yes, it's the only place where we set it to false
cgrellard-ledger
force-pushed
the
feat/llm-ledger-sync-redirection-on-sync-again
branch
from
c5d7221
to
b7aca24
Compare
mcayuelas-ledger
approved these changes
Sep 3, 2024
cgrellard-ledger
deleted the
feat/llm-ledger-sync-redirection-on-sync-again
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Ledger sync redirects on qr code when trying to sync again after a successful sync
Instead of passing the
currentStepand thesetCurrentStepof the activation drawer to every components, we store it with redux and use an action to handle to state of the current step. This gives us more control over it and it allows us to set the step from anywhere❓ Context
🧐 Checklist for the PR Reviewers