Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM - Update Storyly and fixes issues #7841

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Sep 18, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

📝 Description

Update storyly-react-native from 2.18.1 to 3.6.0
Stories are now displayed in the user's app language
Fixes the following issues :

  • Story was closing instead of pausing when user long pressed
  • Story was not displayed on cold app start when triggered by a deep link
  • No more black screen when putting the app in the background in the middle of a story

❓ Context

  • JIRA or GitHub link: LIVE-14103 [LIVE-14119] [LIVE-13778] [LIVE-13857]

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner September 18, 2024 15:20
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 9:49am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 9:49am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 9:49am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 9:49am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 9:49am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Sep 18, 2024
Copy link

socket-security bot commented Sep 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/storyly-react-native@3.6.0 None 0 7.05 MB appsamuraiinc

🚮 Removed packages: npm/storyly-react-native@2.18.1

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants