Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cypress tests (in CircleCI) #10

Closed
LekoArts opened this issue Jul 29, 2019 · 0 comments · Fixed by #16
Closed

Add Cypress tests (in CircleCI) #10

LekoArts opened this issue Jul 29, 2019 · 0 comments · Fixed by #16
Assignees
@LekoArts
Labels
type: enhancement An issue or pull request that adds a feature or enhances a current one

Comments

@LekoArts
Copy link
Owner

Most of my starters have Cypress tests written.

Run Cypress tests on the examples and run them in CircleCI. This should guard against bugs in PRs. The above mentioned existing tests need to be re-evaluated as they might not cover theme specific things.
@LekoArts LekoArts added the type: enhancement An issue or pull request that adds a feature or enhances a current one label Jul 29, 2019
@LekoArts LekoArts self-assigned this Jul 29, 2019
@LekoArts LekoArts changed the title Add Cypress tests in CircleCI Add Cypress tests (in CircleCI) Jul 31, 2019
@LekoArts LekoArts mentioned this issue Aug 1, 2019
Merged
LekoArts added a commit that referenced this issue Aug 2, 2019
@LekoArts
feat: Add Cypress (#16)
ca0ed29 
Fixes #10 

- Adds Cypress
- Adds Cypress to CircleCI testing
- Tests all examples
	- some changes were made to the themes in order to test those
	- tests ensure that all elements are showing correctly in the examples. the functionality around the theme options isn't tested yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LekoArts LekoArts

Labels
type: enhancement An issue or pull request that adds a feature or enhances a current one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add Cypress LekoArts/gatsby-themes
1 participant
@LekoArts