Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve proc macro #158

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Improve proc macro #158

merged 11 commits into from
Oct 17, 2023

Conversation

HaronK
Copy link
Contributor

@HaronK HaronK commented Oct 11, 2023 •
edited
Loading

Changes:

  • Force same line endings in all text files
  • Move libphx.lua and lfs_ffi.lua from ffi to the parent folder
  • Rename folders:
    • ffi -> ffi_common
    • ffiext -> ffi_ext
    • all generated files to ffi_gen
  • Create loader object in the generated FFI files with 2 functions: Loader.declareType() and Loader.defineType()
  • Refactor libphx.lua to first call first Loader.declareType() function of all generated FFI files and then Loader.defineType()
  • Update documentation

@HaronK HaronK marked this pull request as ready for review October 15, 2023 16:05
@HaronK HaronK self-assigned this Oct 15, 2023
This was linked to issues Oct 16, 2023
Automate libphx.lua #124
Closed
Fix line endings for the generated Lua files #145
Closed
dgavedissian
dgavedissian approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@dgavedissian dgavedissian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I fully understand this, but it all looks great to me.

engine/lib/luajit-ffi-gen/src/ffi_generator.rs Outdated Show resolved Hide resolved
@HaronK @dgavedissian
Update engine/lib/luajit-ffi-gen/src/ffi_generator.rs
91d7c6c 
Co-authored-by: David Avedissian <git@dga.dev>
Base automatically changed from haron/fix-audio to main October 17, 2023 06:59
@HaronK HaronK merged commit 1c183d3 into main Oct 17, 2023
4 checks passed
@HaronK HaronK deleted the haron/improve-proc-macro branch October 17, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgavedissian dgavedissian dgavedissian approved these changes

@IllustrisJack IllustrisJack IllustrisJack approved these changes

Assignees

@HaronK HaronK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix line endings for the generated Lua files Automate libphx.lua
3 participants
@HaronK @dgavedissian @IllustrisJack