To resolve the conflict #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
LintaoAmons
reviewed
Aug 2, 2024
| @@ -1,11 +1,12 @@ | |||
| local bookmark_scope = require("bookmarks.domain.bookmark") | |||
| local M = require("bookmarks.domain.bookmark") | |||
There was a problem hiding this comment.
redefined local M. line 1 and line 11
There was a problem hiding this comment.
oh, after merge, I replace all the bookmarks list name to M
LintaoAmons
reviewed
Aug 2, 2024
| @@ -33,9 +33,16 @@ end | |||
| function M.find_bookmark_by_location(self, location) | |||
| -- TODO: self location path | |||
| for _, b in ipairs(self.bookmarks) do | |||
| local b_type = M.get_value_type(b) | |||
There was a problem hiding this comment.
Seems like this commit will fail the sign and line highlight.
And also the original pick method is not working as well
There was a problem hiding this comment.
is there any exception
LintaoAmons
reviewed
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit has merge the bookmark-tree to main