Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: update default time format in zh-cn.yml and zh-tw.yml #711

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

MBRjun
Copy link
Contributor

@MBRjun MBRjun commented Jan 4, 2023

  • In China, the time format used by most people is YYYY/MM/DD(YYYY 年 MM 月 DD 日).

Related issues:

Changes

Update default time format(MMM DD, YYYY -> YYYY 年 M 月 D 日)

  • before
    before

  • after
    after

Testing guide

Checklist

  • I checked the code style with npm run lint
  • I updated the README or the documentation
  • I tested my changes with the current recommended Node LTS version: 16.14.1
  • I tested my changes on all desktop browsers listed below (with their latest versions):
    • Chrome, Firefox and Opera
    • Safari
    • Edge
    • IE 10+
  • I tested my changes on all mobile browsers listed below (with their latest versions):
    • Chrome, Firefox and Opera
    • Safari
    • Edge

This change is Reviewable

- In China, the time format used by most people is YYYY/MM/DD(YYYY 年 MM
  月 DD 日).
@LouisBarranqueiro
Copy link
Owner

👋 @MBRjun, I don't know these languages. What are the motivations for these changes? Getting close to a standard? Could you please share some documentation so I can understand these changes?

- In China, a leading zero in date is mostly not used.
@MBRjun
Copy link
Contributor Author

MBRjun commented Jan 8, 2023

Yes, it's getting close to a standard and more common in China.

The Chinese date format follows the Chinese hierarchical system, which has traditionally been big-endian. Consequently, it correlates with ISO 8601 — year first, month next, and day last (e.g. 2006-01-29). A leading zero is optional in practice, but is mostly not used. Chinese characters that mean year, month, and day are often used as separators (e.g. 2006年1月29日). Since the characters clearly label the date, the year may be abbreviated to two digits when this format is used.

some docs:

@LouisBarranqueiro
Copy link
Owner

Thanks @MBRjun for the details and your help! 🙌

Copy link
Owner

@LouisBarranqueiro LouisBarranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@LouisBarranqueiro LouisBarranqueiro merged commit 4b6f0ff into LouisBarranqueiro:dev Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants