Skip to content

Commit

Permalink
Update actions to use actions/checkout@v3 and actions/setup-python@v4. (
Browse files Browse the repository at this point in the history
#495)

The "[run
tests](https://github.com/MIT-LCP/wfdb-python/blob/main/.github/workflows/run-tests.yml)"
GitHub workflow is raising [several
warnings](https://github.com/MIT-LCP/wfdb-python/actions/runs/9783079800)
about deprecated actions:

e.g.

> `[build (ubuntu-latest,
3.9)](https://github.com/MIT-LCP/wfdb-python/actions/runs/9783079800/job/27011340622)
The following actions uses Node.js version which is deprecated and will
be forced to run on node20: actions/checkout@v2,
actions/setup-python@v2. For more info:
https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/[build
(ubuntu-latest,
3.9)](https://github.com/MIT-LCP/wfdb-python/actions/runs/9783079800/job/27011340622)
The following actions uses Node.js version which is deprecated and will
be forced to run on node20: actions/checkout@v2,
actions/setup-python@v2. For more info:
https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/`

This pull request updates the actions to the latest versions:

- actions/checkout@v2 -> actions/checkout@v3
- actions/setup-python@v2 -> actions/setup-python@v4

Note there is one outdated action that will need addressing at some
point. As of today, the issue does not appear to have been addressed:
actions/checkout#334

```
      # Note: "actions/checkout@v2" requires libstdc++6:amd64 to be
      # installed in the container.  To keep things simple, use
      # "actions/checkout@v1" instead.
      # actions/checkout#334
```
  • Loading branch information
tompollard committed Jul 3, 2024
2 parents 13df748 + 8606bbe commit 634c6a1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ jobs:
os: [windows-latest, ubuntu-latest, macos-latest]
python-version: ["3.8", "3.9", "3.10", "3.11"]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
build-documentation:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down

0 comments on commit 634c6a1

Please sign in to comment.