Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Indent code to ensure 'j' is within for-loop in GQRS algorithm #499

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

tompollard
Copy link
Member

As discussed in #489:

"The variable j was not properly scoped within the for-loop in the sm method, leading to an UnboundLocalError when j was accessed outside the loop."

#489 needs rebasing on the main branch to allow tests to run.

This pull request is just a cherry-pick of the commit in #489, on top of the current version of main (I can't push to the other branch directly, because its on a forked repo).

@tompollard tompollard merged commit edb5f12 into main Jul 10, 2024
14 checks passed
@tompollard tompollard deleted the tp/indent_gqrs branch July 10, 2024 13:42
@tompollard tompollard restored the tp/indent_gqrs branch July 10, 2024 13:42
@tompollard tompollard deleted the tp/indent_gqrs branch July 10, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant