Add new algo audio2pitch #1413
Merged
Add new algo audio2pitch #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogdanov
requested changes
May 14, 2024
… voicing assessment.
|
Okay! It is done. Please check from L192-197, I think this snippet would be nice to add it in all algorithms using AudioLoaders to pass properly the tests in osx. |
dbogdanov
requested changes
Jul 10, 2024
dbogdanov
requested changes
Jul 10, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add a new essntia algorithm, Audio2Pitch. It has been designed for real time pitch extraction.
Before we review everything it would be nice to have an idea of which test could be useful and any suggestions you could have. Kindly.