Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30, fixes #32, fixes #33
The misconception in the linked issue description is that
depends_on "numpy"
should install numpy bindings, whichessentia
requires. However, homebrew's currentnumpy
no longer supportspython3.9
, which is why the build was failing to find numpy. That is also why runningpython3.9 -m pip install numpy
will allowessentia
to build properly, although it is generally not recommended to install python modules to a homebrew python distribution manually.Instead, I've done the following:
brew extract --version=0.29.30 libcython mtg/essentia
libcython
(from homebrew) that uses python3.9python3.9
brew extract --version=1.23.3 numpy mtg/essentia
numpy
(from homebrew) that uses python3.9python3.9
, and use this tap'slibcython
homebrew-core/numpy
conflictpython3.9 -> python
manuallyNote that the formulae i've extracted from
homebrew-core
are just the most recent versions that haddepends_on "python@3.9"
. Newer versions oflibcython
andnumpy
support 3.9 but I didn't want to extract the current version and have to backport it in case there were other changes.slight note: i think that
--with-gaia
bindings might be broken/not fully working, since that formula usespython@3.8
. I can submit a pr later that will update that.