Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download support for MacGap #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add download support for MacGap #100

wants to merge 1 commit into from

Conversation

steedos
Copy link

@steedos steedos commented Apr 11, 2014

Shows downloads progress in Finder and the Downloads stack

Shows downloads progress in Finder and the Downloads stack
@jeff-h
Copy link
Member

jeff-h commented Apr 11, 2014

Ooh! Sounds interesting. I'd really like you to add a note into the README.md explaining how to use your new stuff from the JavaScript side. Would you mind adding this?

Alternatively, feel free to put that info in a comment here. We're probably going to stop putting all this kind of info in the README soon anyway, as it's growing too big. I hope to migrate it all to the Wiki soon.

frame:(WebFrame *)frame
decisionListener:(id < WebPolicyDecisionListener >)listener
{
NSLog (@"%@", type);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove NSLog.

@steedos
Copy link
Author

steedos commented Apr 16, 2014

The current code can go download if browser detect a content type of attachment. But i think if there is a way to use javascript to control download will be better.

Just like PhoneGap:
http://docs.phonegap.com/en/3.2.0/cordova_file_file.md.html#FileTransfer
FileTransfer.download

@steedos
Copy link
Author

steedos commented Apr 16, 2014

@jeff-h
Copy link
Member

jeff-h commented Apr 16, 2014

Thanks for the update. I'll have a play with it over the long weekend.

@@ -196,4 +196,25 @@ + (BOOL) isKeyExcludedFromWebScript:(const char*)name
}


/*
* Download everything except HTML pages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this needs to be mandatory for all use-cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants