adding file icons #244
Merged
adding file icons #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MagicDuck
force-pushed
the
file-icons
branch
from
a96311c
to
d7aac48
Compare
MagicDuck
force-pushed
the
file-icons
branch
from
d7aac48
to
8b963f5
Compare
echasnovski
reviewed
Sep 20, 2024
Comment on lines
+42
to
+54
| local found, lib = pcall(require, 'mini.icons') | ||
| if not found then | ||
| return nil | ||
| end | ||
| -- according to mini.icons docs, need to check this | ||
| -- to make sure setup has been called! | ||
| -- selene: allow(global_usage) | ||
| ---@diagnostic disable-next-line | ||
| if not _G.MiniIcons then | ||
| return nil | ||
| end | ||
|
|
||
| return lib |
There was a problem hiding this comment.
@MagicDuck, hi! Saw your Reddit post about adding support for 'mini.icons' and decided to see if it does the _G.MiniIcons check. It does, thanks for reading 'mini.icons' help page :)
One thing I'd like to mention is that this whole get_lib can be compressed to a single return _G.MiniIcons. This object is both an indication that user has run require('mini.icons').setup() (i.e. opted in for using it and not only has it available from the full 'mini.nvim' install) and the whole require('mini.icons') table itself.
There was a problem hiding this comment.
Haha, no problem! Thank you for building mini.icons! :)
I’ll make a note for myself to update this if I get a chance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #182