Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refacto group module #67

Merged
merged 13 commits into from
Sep 29, 2021
Merged

Refacto group module #67

merged 13 commits into from
Sep 29, 2021

Conversation

kaanyagci
Copy link
Contributor

@kaanyagci kaanyagci commented Sep 28, 2021 •
edited
Loading

[UNRELEASED] - 2021-09-29

Changed

  • File names are changed following the Google Type Script styling guide
  • modules folder was created to contains all modules for the library.
  • Group-related functions are moved in the group module.
  • Some of the existing code is refactored on smaller functions
  • CircleCI configuration updated

@kaanyagci
♻️ group module refactored to a standalone file
85e9526 
All group related functions refactored to group module
@kaanyagci
✨ Group module exported from library
10569f7
@kaanyagci
🚚 files renamed following Google TypeScript styling conventions
dad0310 
all file names are renamed as snake_case and modules folder created to contain modules of the library
@kaanyagci
🔧 tsconfig build info file updated
f830f20
@kaanyagci kaanyagci linked an issue Sep 28, 2021 that may be closed by this pull request
Refacto existing code #66
Closed
@kaanyagci
♻️ more refacto
4f2179e 
functions refactored on smaller functions and some naming issues related to the yesterday's refacto are fixed
@kaanyagci
🔧 configuration files updated
21364ce 
package-lock, tsbuildinfo and .eslintrc files are updated
@kaanyagci
💚 NodeJS image version updated
4bd3cbc 
NodeJS image version updated to the latest in CircleCI configuration
@kaanyagci
💚 Orb version issue fixed
da0ef7c 
The Orb version was incorrect
@kaanyagci
🔧 linter configuration updated
19551b3 
import extensions rule updated
sonatype-lift[bot]
sonatype-lift bot reviewed Sep 29, 2021
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
@kaanyagci kaanyagci self-assigned this Sep 29, 2021
@kaanyagci kaanyagci added ci All changes and requests related to the CI/CD pipelines group Related to the groups module library Related to the npm module (aka. library) P1 Highest priorities labels Sep 29, 2021
@kaanyagci kaanyagci linked an issue Sep 29, 2021 that may be closed by this pull request
Fix CI #68
Open
3 tasks
@kaanyagci kaanyagci merged commit 0589fd2 into development Sep 29, 2021
@kaanyagci kaanyagci deleted the refacto-group-module branch September 29, 2021 21:28
@kaanyagci kaanyagci mentioned this pull request Sep 29, 2021
Closed
@kaanyagci kaanyagci linked an issue Sep 30, 2021 that may be closed by this pull request
Remove groupIds parameters from Options #50
Closed
@kaanyagci kaanyagci mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

@idilsaglam idilsaglam Awaiting requested review from idilsaglam idilsaglam is a code owner

Assignees

@kaanyagci kaanyagci

Labels
ci All changes and requests related to the CI/CD pipelines group Related to the groups module library Related to the npm module (aka. library) P1 Highest priorities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CI Refacto existing code Remove groupIds parameters from Options
1 participant
@kaanyagci