Incorrect folder name is printed for each test

[RalfJung]

In miri, we have a folder compile-fail-fullmir for compile-fail tests that need a different setup than those in compile-fail. This reveals that compiletest prints the wrong path to the file that it is testing:

## Running compile-fail tests in tests/compile-fail-fullmir against miri for target x86_64-unknown-linux-gnu

running 1 test
test [compile-fail] compile-fail/undefined_byte_read.rs ... ok

This says the file name is compile-fail/undefined_byte_read.rs while it really is compile-fail-fullmir/undefined_byte_read.rs. compiletest seems to use the suite name when printing the folder name, which is not in general correct.

I tried to fix this myself, but unfortunately I could not even find the place in the code that does this printing...

[RalfJung]

Ah, I think I found it -- in make_test_name.

[laumann]

That does seem to be a bug... The assumption is that the config.mode is also the name of the directory. Is compile-fail-fullmir available in Config somewhere?

[laumann]

Would it be src_base?

[RalfJung]

@laumann Yes it is in src_base. I am working on a PR for rustc.

[laumann]

Nice :-) Just submit a PR here as well, or ping me when it's in, then I'll replicate it here and release a new version

[laumann]

Looking at miri, you might want to update to compiletest 0.3.0 - it might cause some breakage though as the update changed the type of some fields in Config

[RalfJung]

Well I guess I'll see and fix that breakage as I update to the version that fixes this. ;)

[laumann]

Yeah ok :-) I was just thinking that 0.3.0 is much closer to the current rustc/compiletest, the 0.2 series was getting behind a bit.

[RalfJung]

The upstream rustc PR has been merged.

[laumann]

Nice!

[RalfJung]

Any chance of a release with this fix? :D

[laumann]

Yeah, sure thing :-)

[laumann]

0.3.1 is out

[RalfJung]

Thanks, that was fast. :-)