Skip to content

Commit

Permalink
Rollup merge of rust-lang#34536 - ollie27:rustdoc_module_impls, r=ale…
Browse files Browse the repository at this point in the history
…xcrichton

rustdoc: Fix empty Implementations section on some module pages

These are caused by `DefaultImpl`s.

For example [`core::marker`](https://doc.rust-lang.org/nightly/core/marker/#impls).
  • Loading branch information
Manishearth committed Jun 29, 2016
2 parents b393c7e + f05da01 commit cc15c21
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/librustdoc/html/render.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1696,6 +1696,9 @@ fn item_module(w: &mut fmt::Formatter, cx: &Context,
document(w, cx, item)?;

let mut indices = (0..items.len()).filter(|i| {
if let clean::DefaultImplItem(..) = items[*i].inner {
return false;
}
!cx.maybe_ignore_item(&items[*i])
}).collect::<Vec<usize>>();

Expand Down
15 changes: 15 additions & 0 deletions src/test/rustdoc/module-impls.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![crate_name = "foo"]

pub use std::marker::Send;

// @!has foo/index.html 'Implementations'

0 comments on commit cc15c21

Please sign in to comment.