Add support for pcre2. #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @sebastic I'll test this... |
|
Thanks @sebastic works very well on Windows! (I also made some other minor changes to CMakeLists.txt in this PR to remove some warnings) I think we should merge this. |
Maybe rebase it first to not have such an ugly history? |
|
ok I will try "rebase and merge" (I was initially going to "squash and merge" & remove my history) |
jmckenna
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Add support for pcre2. Fixes: #272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my naive attempt to add support for PCRE2.
It builds successfully, but my C-fu is not very strong, so I'm not sure about the correctness.
@jmckenna can you review this?