Prevent NPE

MarcMil · Apr 17, 2024 · c89a628 · c89a628
1 parent cc91b77
commit c89a628
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/main/java/soot/AbstractASMBackend.java b/src/main/java/soot/AbstractASMBackend.java
@@ -344,10 +344,12 @@ protected void generateMethods() {
                 if (va == null) {
                   continue;
                 }
-                for (AnnotationTag at : va.getAnnotations()) {
-                  AnnotationVisitor av = mv.visitParameterAnnotation(j, at.getType(),
-                      (va.getVisibility() == AnnotationConstants.RUNTIME_VISIBLE));
-                  generateAnnotationElems(av, at.getElems(), true);
+                if (va.hasAnnotations()) {
+                  for (AnnotationTag at : va.getAnnotations()) {
+                    AnnotationVisitor av = mv.visitParameterAnnotation(j, at.getType(),
+                        (va.getVisibility() == AnnotationConstants.RUNTIME_VISIBLE));
+                    generateAnnotationElems(av, at.getElems(), true);
+                  }
                 }
               }
             }

diff --git a/src/main/java/soot/tagkit/VisibilityAnnotationTag.java b/src/main/java/soot/tagkit/VisibilityAnnotationTag.java
@@ -23,6 +23,7 @@
  */
 
 import java.util.ArrayList;
+import java.util.List;
 
 /**
  * Represents the visibility of an annotation attribute attached to a class, field, method or method param (only one of these
@@ -94,7 +95,7 @@ public void addAnnotation(AnnotationTag a) {
     annotations.add(a);
   }
 
-  public ArrayList<AnnotationTag> getAnnotations() {
+  public List<AnnotationTag> getAnnotations() {
     return annotations;
   }