Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow multiple packages in glide get` #96

Closed
hkjn opened this issue Oct 6, 2015 · 4 comments
Closed

Feature request: Allow multiple packages in glide get` #96

hkjn opened this issue Oct 6, 2015 · 4 comments
Milestone

Comments

@hkjn
Copy link

hkjn commented Oct 6, 2015

See title: Similarly to how go get takes one or more packages to download:
$ go get github.com/golang/glog github.com/gorilla/context

I'm suggesting that glide get could work the same way, wheras it currently seems to silently swallow all packages after the first:

$ glide get github.com/golang/glog github.com/gorilla/context
[INFO] Checking dependencies for updates. Godeps: false, GPM: false, gb: false                                         
[INFO] Inspecting /home/zero/src/hkjn.me/googleauth/vendor.                                                            
[INFO] Looking in /home/zero/src/hkjn.me/googleauth/vendor/github.com/golang/glog for a glide.yaml file.
[INFO] Package github.com/golang/glog manages its own dependencies.
@technosophos
Copy link
Member

That makes sense to me.

The one thing we'd be giving up is the (straightforward) ability to create flags specific to a package (like the --version= flag that has been discussed). But that's probably something we could accomplish in another way.

@technosophos
Copy link
Member

@mattfarina I left the cmd.Get function there, even though I believe it is now unused. It functions fine. Is there any reason to keep it, though? Are we treating the public API as frozen even though we're still pre-1.0?

@hkjn Let me know how this functionality feels to you.

technosophos added a commit that referenced this issue Oct 10, 2015
This addresses:

- Issue #92: glide update [repo [repo [repo [...]]]]
- Issue #96: streamlines a bit from previous commits
- Issue #101: do not do redundant work on `glide get foo`
  - Extended that to do the same for `glide update`
- Set the foundation for #85 by adding package list to UpdateReferences.
  However, there's more work to do on #85, including some that will
  break backward compat.
@mattfarina
Copy link
Member

@technosophos let's not consider the public API frozen yet. It will annoy a few people but we're prerelease and GO15VENDOREXPERIMENT is still opt-in. This is a good time for us to make useful changes and annoy as few people as possible.

The only public things I can find calling the cmd package are forks of glide.

@technosophos
Copy link
Member

I think I'd feel better just removing it, then, since otherwise we'll end up maintaining two very similar functions.

technosophos added a commit that referenced this issue Oct 10, 2015
See #96 about removing Get.
@mattfarina mattfarina added this to the 0.7.0 milestone Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants