Load end_of_life JSON database from dynamic path #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installed on a fresh Ruby installation without the source code cloned, the JSON file couldn't be found because it was looking at the cwd of the running process instead of the Gem's lib directory path. I wish that Rubygems had a way of exposing a Gem's installation directory programatically, but I couldn't find it quickly. `Gem.datadir` didn't do what I wanted! So, we'll do it like it's 2014...
MatheusRich
reviewed
Jan 24, 2022
|
@colindean Thanks for the contribution! I left a small comment. If you could fix the small linter error, I'd appreciate it! |
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com>
colindean
commented
Jan 25, 2022
|
🥳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installed on a fresh Ruby installation without the source code
cloned, the JSON file couldn't be found because it was looking at the
cwd of the running process instead of the Gem's lib directory path.
I wish that Rubygems had a way of exposing a Gem's installation
directory programatically, but I couldn't find it quickly.
Gem.datadirdidn't do what I wanted! So, we'll do it like it's 2014...