Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge staging to master #64

Merged
merged 14 commits into from
Jun 26, 2023
Merged

ci: merge staging to master #64

merged 14 commits into from
Jun 26, 2023

Conversation

MatrixAI-Bot
Copy link
Member

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

@MatrixAI-Bot MatrixAI-Bot self-assigned this Jun 26, 2023
@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 911320723 for 7ba545b

https://gitlab.com/MatrixAI/open-source/js-db/-/pipelines/911320723

@ghost
Copy link

ghost commented Jun 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 911641149 for 6088a76

https://gitlab.com/MatrixAI/open-source/js-db/-/pipelines/911641149

@CMCDragonkai
Copy link
Member

There's an issue with systeminformation on the m1 mac.

We get an error:

Error: Command failed: ioreg -c IOPlatformDevice -d 3 -r | grep cluster-type
    at checkExecSyncError (node:child_process:885:11)
    at execSync (node:child_process:957:15)
    at /Users/gitlab/builds/zxQ9CHzH/0/MatrixAI/open-source/js-db/node_modules/systeminformation/lib/cpu.js:652:32
    at ChildProcess.exithandler (node:child_process:411:7)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess.emit (node:domain:489:12)
    at maybeClose (node:internal/child_process:1091:16)
    at Socket.<anonymous> (node:internal/child_process:449:11)
    at Socket.emit (node:events:513:28) {
  status: 1,
  signal: null,
  output: [ null, Buffer(0) [Uint8Array] [], Buffer(0) [Uint8Array] [] ],
  pid: 34634,
  stdout: Buffer(0) [Uint8Array] [],
  stderr: Buffer(0) [Uint8Array] []
}

However testing on my local m1 mac I can see this working.

It's possible that on the CI maybe there's a missing command. Possibly ioreg doesn't exist or grep doesn't exist. Let's see.

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 911671923 for 465e5a2

https://gitlab.com/MatrixAI/open-source/js-db/-/pipelines/911671923

@CMCDragonkai
Copy link
Member

There's an issue with systeminformation on the m1 mac.

We get an error:

Error: Command failed: ioreg -c IOPlatformDevice -d 3 -r | grep cluster-type
    at checkExecSyncError (node:child_process:885:11)
    at execSync (node:child_process:957:15)
    at /Users/gitlab/builds/zxQ9CHzH/0/MatrixAI/open-source/js-db/node_modules/systeminformation/lib/cpu.js:652:32
    at ChildProcess.exithandler (node:child_process:411:7)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess.emit (node:domain:489:12)
    at maybeClose (node:internal/child_process:1091:16)
    at Socket.<anonymous> (node:internal/child_process:449:11)
    at Socket.emit (node:events:513:28) {
  status: 1,
  signal: null,
  output: [ null, Buffer(0) [Uint8Array] [], Buffer(0) [Uint8Array] [] ],
  pid: 34634,
  stdout: Buffer(0) [Uint8Array] [],
  stderr: Buffer(0) [Uint8Array] []
}

However testing on my local m1 mac I can see this working.

It's possible that on the CI maybe there's a missing command. Possibly ioreg doesn't exist or grep doesn't exist. Let's see.

I may report this in https://gitlab.com/gitlab-org/ci-cd/shared-runners/infrastructure/-/issues/76.

Right now I'm just checking which specific command fails:

    - ioreg -c IOPlatformDevice -d 3 -r
    - ioreg -c IOPlatformDevice -d 3 -r | grep cluster-type

@CMCDragonkai
Copy link
Member

Ok nailed it to the grep command. It doesn't exist on the new macos image... I wonder if there's a way to ensure it is installed, perhaps through brew.

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 911691585 for 9616139

https://gitlab.com/MatrixAI/open-source/js-db/-/pipelines/911691585

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 911706440 for aeff66e

https://gitlab.com/MatrixAI/open-source/js-db/-/pipelines/911706440

@CMCDragonkai
Copy link
Member

Ok it appears it's not because grep doesn't exist. It appears it's because the information does not exist and grep returns 1 as exit code. It seems systeminformation expects this information to exist.

Reported upstream as I think systeminformation should be less strict: sebhildebrandt/systeminformation#823

@tegefaulkes

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jun 26, 2023

The only quick fix is to disable the cpu information until it's fixed upstream. That's in the benches/index.ts:

  const systemData = await si.get({
    cpu: '*', // <-- need to comment out
    osInfo: 'platform, distro, release, kernel, arch',
    system: 'model, manufacturer',
  });

We could apply a patch inside the build macos job that applies to the benches/index.ts for now.

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 911731736 for 952d192

https://gitlab.com/MatrixAI/open-source/js-db/-/pipelines/911731736

@MatrixAI-Bot
Copy link
Member Author

Pipeline Succeeded on 911731736 for 952d192

https://gitlab.com/MatrixAI/open-source/js-db/-/pipelines/911731736

@MatrixAI-Bot MatrixAI-Bot merged commit 952d192 into master Jun 26, 2023
2 checks passed
@MatrixAI-Bot MatrixAI-Bot temporarily deployed to github-pages June 26, 2023 10:35 — with GitHub Pages Inactive
@CMCDragonkai
Copy link
Member

Upstream has fixed it. Just use 5.18.5 of `systeminformation.

    "systeminformation": "^5.18.5",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants