fix(woof): make command safe

Mattlk13 · Oct 5, 2020 · 8016ae2 · 8016ae2
1 parent 7c7d579
commit 8016ae2
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/src/cli/commands/woof.ts b/src/cli/commands/woof.ts
@@ -1,9 +1,5 @@
 import { MethodArgs, ArgsOptions } from '../args';
 
-interface WoofOptions {
-  language?: string; // ISO 639-1 code
-}
-
 const woofs = {
   en: 'Woof!',
   he: ' !הב ',
@@ -12,13 +8,16 @@ const woofs = {
   cs: ' Haf!',
 };
 
-export = function woof(...args0: MethodArgs) {
-  const args = [...args0];
-  let options: WoofOptions = {};
-  if (typeof args[args.length - 1] === 'object') {
-    options = (args.pop() as ArgsOptions) as WoofOptions;
+export = function woof(...args: MethodArgs) {
+  const options = args.pop() as ArgsOptions;
+  let lang = 'en';
+
+  if (
+    typeof options.language === 'string' &&
+    Object.keys(woofs).includes(options.language)
+  ) {
+    lang = options.language;
   }
-  const lang = options.language || 'en';
   console.log(`
     |         |
    /|         |\\