Adapt PR and release jobs to enable testing of the Framework repo #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Pass the branch name along the call chain instead. This is in preparation for testing multiple branches in the same job. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Each branch listed in MBED_TLS_BRANCH (separated by commas) will be checked out and tested in parallel. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
dev/bensze01/framework
branch
2 times, most recently
from
9d3e7ed
to
169671d
Compare
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
IllegalAccessError doesn't match the semantics used here. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
dev/bensze01/framework
branch
from
169671d
to
5c04cf3
Compare
This fixes checkouts for productions jobs that target the framework repo. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
When analyze_results() was converted to run inside a docker container, the outer call to instantiate a helper-container-host node was not removed, resulting in analysis running on a regular container-host, in addition to the unused outer container. Restore the intended behaviour by removing the outer call and modifying gen_jobs.gen_docker_job() to allow overriding the node the docker job is run on. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
This commit also refactors failed_builds and outcome_stashes to be per-branch values by moving them inside BranchInfo. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
dev/bensze01/framework
branch
from
60272b5
to
4eec09e
Compare
It looks like Set.empty is bugged on our Jenkins installation, evaluating as false even if the set has 0 elements. Coercion to a boolean works as expected. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the testing of the framework repo, by adapting the existing jobs to allow overriding the version of the framework checked out by the CI, as well as enabling the testing of multiple branches of Mbed TLS in a single job.
The framework version is controlled by the newly defined parameters
FRAMEWORK_REPOandFRAMEWORK_BRANCH, whileMBEDTLS_BRANCHhas been extended to allow specifying multiple branches separated by,.For automatic PR testing,
mbedtls.run_framework_pr_job()is added as an entrypoint, which is called by the Jenkinsfile added by the companion PR Mbed-TLS/mbedtls-framework#33Tests: