Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand: refactor for a11y #339

Closed
McShelby opened this issue Oct 7, 2022 · 2 comments
Closed

expand: refactor for a11y #339

McShelby opened this issue Oct 7, 2022 · 2 comments
Labels
browser This is a topic related to the browser but not the theme change Introduces changes with existing installations feature New feature or request
Milestone
5.11.0

Comments

@McShelby
Copy link
Owner

McShelby commented Oct 7, 2022 •
edited
Loading

The expand shortcode has issues with WCAG as it does not carry any aria labels.

Additionally, the logic uses jQuery (which we want to get rid of in the long term), the CSS is complicated and the code for search support adheres to this complexity.

Better way would be, to implement the logic using an input-checkbox like for the expander of the menu. By that, we get WCAG almost for free and do not need any javascript besides of search support.

Downside is, that like the menu implementation the expander icon would not show up in Internet Explorer 11.
@McShelby McShelby added feature New feature or request helpwanted Great idea, send in a PR and removed helpwanted Great idea, send in a PR labels Oct 7, 2022
@McShelby McShelby changed the title expander: refactor expander: refactor for a11y Nov 6, 2022
@McShelby McShelby added blocked Depends on other issue to be fixed first browser This is a topic related to the browser but not the theme labels Nov 6, 2022
@McShelby
Copy link
Owner Author

McShelby commented Nov 6, 2022

Wait until IE11 is deprecated

@McShelby McShelby changed the title expander: refactor for a11y expand: refactor for a11y Jan 25, 2023
@McShelby McShelby removed the blocked Depends on other issue to be fixed first label Feb 1, 2023
@McShelby McShelby added this to the 5.11.0 milestone Feb 1, 2023
@McShelby
Copy link
Owner Author

McShelby commented Feb 1, 2023

Because we are now refactoring the implementation for the removal of jQuery #452, we also deal with this issue now.

@McShelby McShelby added the change Introduces changes with existing installations label Feb 1, 2023
McShelby added a commit that referenced this issue Feb 3, 2023
@McShelby
expand: a11y and remove jQuery #339 #452
00faf15
@McShelby McShelby closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser This is a topic related to the browser but not the theme change Introduces changes with existing installations feature New feature or request
Projects
None yet
Milestone
5.11.0
Development

No branches or pull requests
1 participant
@McShelby