Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: fix oddities in keyboard handling #463

Closed
McShelby opened this issue Feb 3, 2023 · 0 comments
Closed

search: fix oddities in keyboard handling #463

McShelby opened this issue Feb 3, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@McShelby
Copy link
Owner

McShelby commented Feb 3, 2023

  • on ESC, close overlay without deleting search term if overlay is open
  • on ESC, delete search term if overlay is closed
  • on ESC set focus back to document if search term is empty
  • on UP, preventDefault to keep cursor in position
@McShelby McShelby added the bug Something isn't working label Feb 3, 2023
@McShelby McShelby added this to the 5.11.0 milestone Feb 3, 2023
@McShelby McShelby self-assigned this Feb 3, 2023
@McShelby McShelby closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant