Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update all available actions to nodejs 20 #802

Closed
McShelby opened this issue Mar 15, 2024 · 6 comments
Closed

build: update all available actions to nodejs 20 #802

McShelby opened this issue Mar 15, 2024 · 6 comments
Assignees
Labels
task Maintainence work
Milestone

Comments

@McShelby
Copy link
Owner

McShelby commented Mar 15, 2024

Painful. GitHub deprecates actions stuff constantly, so it's always necessary to adjust.

Probably a good future step is, to consolidate action usage by relying on well maintained ones.

@McShelby McShelby added the task Maintainence work label Mar 15, 2024
@McShelby McShelby added this to the 5.26.0 milestone Mar 15, 2024
@McShelby McShelby self-assigned this Mar 15, 2024
@cagix
Copy link

cagix commented Mar 15, 2024

@McShelby that's where Dependabot shines :)

@McShelby
Copy link
Owner Author

Hm, I always thought, this is only used for file dependencies.

Here (see my changeset above), it would need to change code in source files. Are you sure this is doable with dependabot? Do you have an example repo (not necessarily yours) where I can take a look?

Anyways this does not help with non-maintained actions.

@cagix
Copy link

cagix commented Mar 16, 2024

well, it handles the workflow/action versions quite well... it even supports docker, gradle, npm, ...

have a look at my dungeon project, where we use it for workflows/actions and gradle: https://github.com/Dungeon-CampusMinden/Dungeon/blob/master/.github/dependabot.yml
here another example of updating just the gh-actions in my workflows: https://github.com/Compiler-CampusMinden/CB-Vorlesung-Bachelor/blob/master/.github/dependabot.yml

here is how to configure your repo (you'll need a config file plus some settings in your repo): https://docs.github.com/en/code-security/dependabot/working-with-dependabot

it will add a pull-request for each detected update, and in this pull-request it gives you many options: you could accept/merge, you could tell dependabot to ignore this specific dependency, ...

@cagix
Copy link

cagix commented Mar 16, 2024

here an example pull-request, where i declined the suggested update: Programmiermethoden-CampusMinden/student-support-code-template#1

you can see, dependabot wanted to change my build.gradle ...

sadly i have not found an example for updating gh-actions in .github/workflows/....yaml, obviously i've been keeping my actions up too date to well 🤣

@McShelby
Copy link
Owner Author

@cagix Thanks for the hints. I'll take a look into it.

@cagix
Copy link

cagix commented Mar 16, 2024

you can fork https://github.com/dependabot/demo to try your config :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Maintainence work
Projects
None yet
Development

No branches or pull requests

2 participants