Roslyn.sln discovery aborted after 30K tests.

[navin22]

Description

Roslyn.sln discovery aborts after discovering 31010 tests. The active Tests Discovery was aborted is the message displayed in the Tests Output window.

Steps to reproduce

Copy "\svajjala-srv\Share\RoslynTest.zip" folder to your machine.
Unzip it.
Enable TPV2
Open the Roslyn.sln from the unzipped location.

Expected behavior

Discovery should complete normally, by discovering around 58K tests.

Actual behavior

The Active Tests Discovery was aborted. After discovering 31010.

Environment

VS Build : D15rel/15.0.25913.0

Note

This is happening only with TPV2. TPV1 is able to discover 58K odd tests.

[navin22]

Getting below exception in vstest.console.exe

$exception.InnerException
{"An item with the same key has already been added."}
Data: {System.Collections.ListDictionaryInternal}
HResult: -2146233033
HelpLink: null
IPForWatsonBuckets: {1930145076}
InnerException: {"An item with the same key has already been added."}
IsTransient: false
Message: "An item with the same key has already been added."
RemoteStackTrace: null
Source: "Microsoft.VisualStudio.TestPlatform.ObjectModel"
StackTrace: " at Microsoft.VisualStudio.TestPlatform.ObjectModel.TestObject.ConvertPropertyFrom[T](TestProperty property, CultureInfo culture, Object value)\r\n at Microsoft.VisualStudio.TestPlatform.ObjectModel.TestObject.SetPropertyValue[T](TestProperty property, T value, CultureInfo culture)\r\n at Microsoft.VisualStudio.TestPlatform.ObjectModel.TestObject.set_StoreKeyValuePairs(List`1 value)\r\n at SetStoreKeyValuePairs(Object , Object )\r\n at Newtonsoft.Json.Serialization.DynamicValueProvider.SetValue(Object target, Object value)"
TargetSite: {System.Object ConvertPropertyFrom[T](Microsoft.VisualStudio.TestPlatform.ObjectModel.TestProperty, System.Globalization.CultureInfo, System.Object)}
WatsonBuckets: null
_HResult: -2146233033
_className: null
_data: {System.Collections.ListDictionaryInternal}
_dynamicMethods: {object[2]}
_exceptionMethod: {System.Object ConvertPropertyFrom[T](Microsoft.VisualStudio.TestPlatform.ObjectModel.TestProperty, System.Globalization.CultureInfo, System.Object)}
_exceptionMethodString: null
_helpURL: null
_innerException: {"An item with the same key has already been added."}
_ipForWatsonBuckets: {1930145076}
_message: "An item with the same key has already been added."
_remoteStackIndex: 0
_remoteStackTraceString: null
_safeSerializationManager: {System.Runtime.Serialization.SafeSerializationManager}
_source: "Microsoft.VisualStudio.TestPlatform.ObjectModel"
_stackTrace: {sbyte[96]}
_stackTraceString: null
_watsonBuckets: null
_xcode: -532462766
_xptrs: {0}

[navin22]

RCA for the Issue : In TPv2 We are not supporting multiple custom test property with the same name and different value. For Eg: Test with below adornment will fail discovery
[TestProperty("Feature", "Dummy")]
[TestProperty("Feature", "Dummy2")]

[navin22]

#328 PR has fixed this issue.