Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testplatform to v15.0.0-preview-20170123-02. #711

Merged
merged 2 commits into from
Jan 25, 2017
Merged

Update testplatform to v15.0.0-preview-20170123-02. #711

merged 2 commits into from
Jan 25, 2017

Conversation

codito
Copy link
Contributor

@codito codito commented Jan 23, 2017

Fixes part of this release:

  • Allow multiple test properties with same key #239, #358
  • Localization for testplatform vsix package #146
  • Working directory should be set to test source parent directory #311
  • Allow relative source paths to vstest.console #331
  • Stacktrace and error message should be in context of failed test #285

@srivatsn
Copy link
Contributor

Tagging @MattGertz for approval.

@srivatsn srivatsn added this to the 1.0 RTM milestone Jan 23, 2017
@MattGertz
Copy link

@srivatsn Template? I'm not clear what these are.

@srivatsn
Copy link
Contributor

Ah yes- @codito can you please fill out the escrow template from here - https://github.com/dotnet/roslyn-project-system/blob/master/.github/PULL_REQUEST_TEMPLATE.md

@sbaid
Copy link

sbaid commented Jan 24, 2017 •
edited
Loading

@MattGertz @srivatsn @codito Bug 371113:TestPlatform RTW fixes insertion -- has askmode template details.

@natidea
Copy link
Contributor

natidea commented Jan 24, 2017

Approved to merge via 373305

@srivatsn
Copy link
Contributor

@dotnet-bot test this please.

@srivatsn
Copy link
Contributor

@333fred any idea what's happening here? Is this due to #632?

@333fred
Copy link
Member

333fred commented Jan 24, 2017

Probably. I'm going to revert it.

@srivatsn
Copy link
Contributor

@dotnet-bot test this please

1 similar comment
@333fred
Copy link
Member

333fred commented Jan 24, 2017

@dotnet-bot test this please

@333fred
Copy link
Member

333fred commented Jan 24, 2017

Submitted #721 to fix the issue. The feature/msbuild branch was deleted from the CLI repo, and new clones are broken.

@333fred
Copy link
Member

333fred commented Jan 24, 2017

@codito, can you please merge master into your branch to get the build fix I just merged?

@srivatsn srivatsn merged commit c947a87 into dotnet:master Jan 25, 2017
mmitche pushed a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20190…
3a36ba3 
…613.18 (dotnet#711)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19313.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srivatsn srivatsn srivatsn approved these changes

Assignees
No one assigned
Labels
Approved to merge
Projects
None yet
Milestone
1.0 RTM
Development

Successfully merging this pull request may close these issues.
7 participants
@codito @srivatsn @MattGertz @sbaid @natidea @333fred @dnfclas