Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One of the title in the Edit camp page is not clear [Bug] [FrontEnd] #708

Closed
ozsoffy opened this issue Mar 4, 2018 · 0 comments
Closed

One of the title in the Edit camp page is not clear [Bug] [FrontEnd] #708

ozsoffy opened this issue Mar 4, 2018 · 0 comments

Comments

@ozsoffy
Copy link

ozsoffy commented Mar 4, 2018 •
edited
Loading

The Problem:
Title in the Edit camp page is not clear

Steps:

  1. Go to stage spark page
    https://spark.staging.midburn.org/he/login?r=/
  2. login using 'Camp manager' profile:
    midqacamp@gmail.com
    Pass: qa123456
  3. click on menu > my camp > edit camp (or the following link:)
    https://spark.staging.midburn.org/he/camps/2045/edit

Result:
The copy of one of the titles is wrong 'פרסום באתר'

Expected:
The copy of one of the title 'פרסום באתר' needs to be 'פרסום המחנה באתר מידבן'
see screenshot

image
@ozsoffy ozsoffy changed the title One of the title in the Edit camp page is not clear One of the title in the Edit camp page is not clear [Bug] Mar 4, 2018
@ozsoffy ozsoffy changed the title One of the title in the Edit camp page is not clear [Bug] One of the title in the Edit camp page is not clear [Bug] [FrontEnd] Mar 4, 2018
shaniqwa added a commit that referenced this issue Mar 7, 2018
@shaniqwa
fix UI Bug #708 : change title in edit camp page
4d4592a
@amotenko amotenko mentioned this issue Mar 8, 2018
Merged
amotenko pushed a commit that referenced this issue Mar 8, 2018
@shaniqwa @amotenko
Ui style improvment and fixes (#733)
5289eab 
* fix UI Bug #708 : change title in edit camp page

* fix UI Bugs #711 & #712  (camp page)

* fix UI Bugs #711 & #712  (camp page)

* UI Bug fix #710 - remove publish button

* UI main navigation - remove unnecessary class 'undefined'

* add he translations

* edit camp - general comments and layout fix

* minor style changes, remove underline when hovering buttons, align checkboxes to labels

* fix top navbar style

* add moment.js to app.locals so it can be used for date formatting in jade templates. use to format date in edit camp page. use angular date pipe in index_admin page.

* add some style: to statistics on home page and members table.

* fix translation, add icon to 'inactive' status
shaniqwa added a commit that referenced this issue Mar 22, 2018
@shaniqwa
Merge remote-tracking branch 'midburn/ui-style-fixes' into shani-ui-s…
a4cff94 
…tyle-fixes

* midburn/ui-style-fixes:
  fix translation, add icon to 'inactive' status
  add some style: to statistics on home page and members table.
  add moment.js to app.locals so it can be used for date formatting in jade templates. use to format date in edit camp page. use angular date pipe in index_admin page.
  fix top navbar style
  minor style changes, remove underline when hovering buttons, align checkboxes to labels
  edit camp - general comments and layout fix
  add he translations
  UI main navigation - remove unnecessary class 'undefined'
  UI Bug fix #710 - remove publish button
  fix UI Bugs #711 & #712  (camp page)
  fix UI Bugs #711 & #712  (camp page)
  fix UI Bug #708 : change title in edit camp page
shaniqwa added a commit that referenced this issue Mar 23, 2018
@shaniqwa
Merge remote-tracking branch 'midburn/master' into ui-style-fixes
5aa0257 
* midburn/master:
  fix camp selection content (#782)
  continuous deployment from api-refactor-feb-2018 to sparktesting environment (#770)
  enable continuous deployment for spark-drupal-sync (#763)
  Sorting using ng-repeat filter sortBy (#741)
  Tagging v2.10.30
  Update package.json
  fixed incorrect tickets number displayed (#739)
  Fixed for unsynced tickets (#737)
  Fixed code in free text in the camp page (#713) (#736)
  Fix ticket sync from Drupal (#734)
  Tagging v2.10.27
  update docs for import pre sale ticket allocations (#732)
  Ui style improvment and fixes (#733)
  Ui Bugs fixed: #708, #710, #711, #712 (#726)
  bumping version to v2.10.26
  Bundle IDs should be int, not string (#729)
  Added correct bundle IDs for 2018 sale (#727)

# Conflicts:
#	public/stylesheets/_camps.scss
#	public/stylesheets/_colors.scss
#	public/stylesheets/main.scss
#	views/includes/page.jade
#	views/pages/camps/index_user.jade
amotenko pushed a commit that referenced this issue Mar 24, 2018
@shaniqwa @amotenko
Ui style and fixes (#786)
cb156d6 
* fix UI Bug #708 : change title in edit camp page

* fix UI Bugs #711 & #712  (camp page)

* fix UI Bugs #711 & #712  (camp page)

* UI Bug fix #710 - remove publish button

* UI main navigation - remove unnecessary class 'undefined'

* add he translations

* edit camp - general comments and layout fix

* minor style changes, remove underline when hovering buttons, align checkboxes to labels

* fix top navbar style

* add moment.js to app.locals so it can be used for date formatting in jade templates. use to format date in edit camp page. use angular date pipe in index_admin page.

* add some style: to statistics on home page and members table.

* fix translation, add icon to 'inactive' status

* update top nav: put all admin manage tabs under one dropdown. fix bug in whoami page (was getting error when logged in with user without camp).

* theme styling

* link to button

* layout fix

* add theme toggle (button in footer) - new theme is now default, white theme available. fix some breadcrumbs.
amotenko pushed a commit that referenced this issue Mar 25, 2018
@shaniqwa @amotenko
Ui style fixes (#787)
f5aa671 
* fix UI Bug #708 : change title in edit camp page

* fix UI Bugs #711 & #712  (camp page)

* fix UI Bugs #711 & #712  (camp page)

* UI Bug fix #710 - remove publish button

* UI main navigation - remove unnecessary class 'undefined'

* add he translations

* edit camp - general comments and layout fix

* minor style changes, remove underline when hovering buttons, align checkboxes to labels

* fix top navbar style

* add moment.js to app.locals so it can be used for date formatting in jade templates. use to format date in edit camp page. use angular date pipe in index_admin page.

* add some style: to statistics on home page and members table.

* fix translation, add icon to 'inactive' status

* update top nav: put all admin manage tabs under one dropdown. fix bug in whoami page (was getting error when logged in with user without camp).

* theme styling

* link to button

* layout fix

* add theme toggle (button in footer) - new theme is now default, white theme available. fix some breadcrumbs.

* fix missing cards div in homepage and manage files

* fix form layout in homepage

* add suppliers to top nav bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amotenko @ozsoffy