When parsing an XML result file fails, don't fail while merging subsequent test results #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quent test results Signed-off-by: Jonathan Schear <[email protected]>
jschear
force-pushed
the
js/bugfix_invalid_xml_breaks_merging
branch
from
2e472ac
to
afd8e3c
Compare
|
I'm not sure if the failing check is related to my changes. It looks like the same test failed on master: https://github.com/MobileNativeFoundation/bluepill/runs/3747110142?check_suite_focus=true |
ob
approved these changes
Nov 15, 2021
|
I saw some executions where this happened and I see how this could skip the subsequent reports that might be perfectly valid. Thanks again for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, when parsing an XML result file fails, all subsequent reports are skipped because the
NSErrorinstance is being reused. This PR fixes that issue and adds a test case.