Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-19024] Fix passing custom JDBC options to Greenplum.extra #308

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Aug 27, 2024

Change Summary

Add options passed to Greenplum(extra={"some": "value"}) to JDBC URL query part.
Add unit tests.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (c6b09be) to head (6c4e8da).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #308      +/-   ##
===========================================
+ Coverage    95.25%   95.40%   +0.15%     
===========================================
  Files          225      225              
  Lines         8940     8949       +9     
  Branches      1516     1518       +2     
===========================================
+ Hits          8516     8538      +22     
+ Misses         302      290      -12     
+ Partials       122      121       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus requested a review from TiGrib August 27, 2024 13:23
@dolfinus dolfinus marked this pull request as ready for review August 27, 2024 13:24
@dolfinus dolfinus enabled auto-merge (rebase) August 28, 2024 12:56
@dolfinus dolfinus disabled auto-merge August 28, 2024 12:57
@dolfinus dolfinus merged commit 98a5784 into develop Aug 28, 2024
33 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-19024 branch August 28, 2024 12:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants