Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNI QA] Subcategories — drag to scroll on desktop #7787

Closed
sabrinang opened this issue Nov 5, 2021 · 8 comments · Fixed by #7900
Closed

[PNI QA] Subcategories — drag to scroll on desktop #7787

sabrinang opened this issue Nov 5, 2021 · 8 comments · Fixed by #7900
Assignees
Labels
a11y Accessibility buyer's guide 🛍 Issues related to the buyer's guide engineering frontend qa
Milestone

Comments

@sabrinang
Copy link

For people who aren't using a track pad or wheeled mouse, it would be good to be able to drag-to-scroll to see the additional subcategories
sTpcOsTW8K

@sabrinang sabrinang added buyer's guide 🛍 Issues related to the buyer's guide qa a11y Accessibility labels Nov 5, 2021
@sabrinang sabrinang added this to the PNI Q3 2021 milestone Nov 5, 2021
@fessehaye fessehaye self-assigned this Nov 5, 2021
@Pomax
Copy link
Contributor

Pomax commented Nov 8, 2021

Doesn't the desktop give you a scrollbar (always, on windows, and when you mouse-over, on mac)?

@benhohner
Copy link
Contributor

@kristinashu What do you think of having the categories wrap to a new line on desktop? I feel like the scroll interaction pattern is not very common on desktop vs mobile.

@benhohner
Copy link
Contributor

P1

@kristinashu
Copy link

Let's pause on this one. I think the screen cap is from when there was a bug on staging, that @fessehaye has since fixed. Let's see if this is still an issue once Simon's mobile updates have been pushed live and once all the real content is live with real sub-categories.

@kristinashu kristinashu self-assigned this Nov 8, 2021
@kristinashu
Copy link

@sabrinang can you please try this again now that the mobile updates are live?

@sabrinang
Copy link
Author

@kristinashu I tested what is live and the tags scroll and work on mobile screens as the users can swipe over and it is fine on wide desktop where all tags are in view. The scrollbar is hidden as it clutters up the category tag UI area. However the issue remains for people who view this on a narrow viewport who are without a trackpad or a wheeled mouse holding shift, that they would not be able to access the additional categories.

  • I think what Ben suggested of having the tags wrap would work to not encounter this issue. If we unhide the scrollbar that would also help with this issue like what Pomax said but it will add additional UI element not in the mockup. So it'd be good to check-in with @nancyt1 to see what was originally intended for narrower desktop interactions as it may have been considered already during mockup phase
  • I also noticed the category tags lose the left margin as the tags start past the edge of the left side of the screen

Not sure if it is intuitive but for me I try to click and drag to see more when I use my mouse so that was my initial recommendation (if I use my laptop trackpad then I can see the rest of the tags):
https://user-images.githubusercontent.com/2492510/141545558-c048dafd-22c0-46d4-abb3-43ccd524fff8.mov

@kristinashu
Copy link

Ah ok, I see what you mean now about now!

@fessehaye @nancyt1 @sabrinang do you want to set up a time to chat through this to figure out the best solution?

@kristinashu kristinashu assigned nancyt1 and sabrinang and unassigned kristinashu Nov 15, 2021
@fessehaye
Copy link
Contributor

P2 now

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility buyer's guide 🛍 Issues related to the buyer's guide engineering frontend qa
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants